[GSK-1956] Moved target validation and silenced it for LLMs #1531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@rabah-khalek can you check the unit tests? |
mattbit
requested changes
Nov 3, 2023
Comment on lines
+23
to
+24
| if model.meta.model_type != SupportedModelTypes.TEXT_GENERATION and validate_ds is not None: | ||
| validate_optional_target(validate_ds) |
Member
There was a problem hiding this comment.
Why do we need this in validate_model???
Contributor
Author
There was a problem hiding this comment.
we should refactor model_validation and dataset_validation into one common validation, but the way the code is structured right now, I needed model.meta.model_type to do validate_optional_target for non-LLM models.
Contributor
Author
There was a problem hiding this comment.
Let's just fix the llm-warning issue for now and deal with the refactoring post-release, I added a card here: https://linear.app/giskard/issue/GSK-2064/refactor-model-and-dataset-validation
|
Kudos, SonarCloud Quality Gate passed! |
mattbit
approved these changes
Nov 7, 2023
Member
mattbit
left a comment
mattbit
left a comment
There was a problem hiding this comment.
Good but we should consider refactoring this soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1527